Docs: Correct parameter variable name in WP_REST_Icons_Controller#11040
Docs: Correct parameter variable name in WP_REST_Icons_Controller#11040Soean wants to merge 1 commit intoWordPress:trunkfrom
WP_REST_Icons_Controller#11040Conversation
… `WP_REST_Icons_Controller`
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
apermo
left a comment
There was a problem hiding this comment.
LGTM, did you check if there are other similar errors in the same file?
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Thanks for the PR! Merged in r61739. |
Changed the parameter name in the docblock from
$_requestto$requestin theget_items_permissions_checkmethod ofWP_REST_Icons_Controllerto match the actual parameter name.Trac ticket: https://core.trac.wordpress.org/ticket/64224
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.