HTML API: Align STYLE tag contents escaping with SCRIPT tag #10668
+71
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
6ff95c3 to
9f2f45b
Compare
westonruter
reviewed
Jan 14, 2026
Comment on lines
+4251
to
+4275
| /* | ||
| * Replace all instances of the ASCII case-insensitive match of "</style" | ||
| * when followed by whitespace or "/" or ">", by using a CSS Unicode | ||
| * escape sequence for the "s" (or the "S"). | ||
| * | ||
| * CSS Unicode escape sequences will terminate at the first non-hexadecimal, | ||
| * so the `t` character in `style` ensures that a Unicode escape sequence | ||
| * like `\73t` is correctly interpreted as `st`. | ||
| */ | ||
| while ( $at < $end ) { | ||
| $tag_at = stripos( $text, '</style', $at ); | ||
| if ( false === $tag_at ) { | ||
| break; | ||
| } | ||
|
|
||
| if ( 1 !== strspn( $text, " \t\f\r\n/>", $tag_at + 7, 1 ) ) { | ||
| $at = $tag_at + 7; | ||
| continue; | ||
| } | ||
|
|
||
| $escaped .= substr( $text, $was_at, $tag_at - $was_at + 2 ); | ||
| $escaped .= 's' === $text[ $tag_at + 2 ] ? '\73' : '\53'; | ||
| $was_at = $tag_at + 3; | ||
| $at = $tag_at + 8; | ||
| } |
Member
There was a problem hiding this comment.
Would there be an opportunity to factor this out into a common method to be reused by both escape_style_contents and escape_javascript_script_contents?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10635 is merged here. It should land first so that this approach can align with what finally lands there.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.