Backport new entity block binding binding#10141
Closed
getdave wants to merge 1 commit intoWordPress:trunkfrom
Closed
Backport new entity block binding binding#10141getdave wants to merge 1 commit intoWordPress:trunkfrom
getdave wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Comment on lines
+52
to
+54
| if ( is_wp_error( $permalink ) ) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
The get_permalink() return either string or bool false why we check is_wp_error here?
Contributor
Author
There was a problem hiding this comment.
That's just an error on my part which we need to fix.
Contributor
Author
|
As we have now refactored the implementation to use the existing Post and Term bindings there is no need for a backport. Closing this one out. cc @ockham |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of WordPress/gutenberg#71630
Trac ticket: https://core.trac.wordpress.org/ticket/64074
Please note that we are aiming to remove the need for this binding as part of WordPress/gutenberg#72165.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.