wp_die() updates for the Upgrade / Install component#10097
wp_die() updates for the Upgrade / Install component#10097CallumBW95 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
…s related to the Upgrade / Install component
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-admin/setup-config.php
Outdated
| '<code>wp-config-sample.php</code>' | ||
| ) | ||
| ), | ||
| 404 |
There was a problem hiding this comment.
I wonder if 404 is the correct code here. The client doesn't request the wp-config-sample.php file directly. The backend tries to load it but can't. I could see this being a 500, but curious to hear other opinions.
There was a problem hiding this comment.
I have done some reading around this, and it's definitely not a client issue, so a 4xx error would not be correct. I believe this one can be turned back into a 500 error as this is due to a missing file on the server. I will update this now.
mindctrl
left a comment
There was a problem hiding this comment.
Looks good overall. Left a thought about the 404 code in setup-config.php.
Update wp_die() to include status codes where appropriate within files related to the Upgrade / Install component
Trac ticket: #64058
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.