Add expiration to transient to prevent it from being autoloaded.

Felix Arntz · Felix Arntz · commit d0f971ffc280 · 2023-10-12T10:45:22.000-05:00
diff --git a/src/wp-includes/block-template-utils.php b/src/wp-includes/block-template-utils.php
@@ -569,7 +569,7 @@ function _get_block_template_file_content( $template_file_path ) {
 	$template_data['template_content'][ $relative_path ] = file_get_contents( $template_file_path );
 
 	// Update the cache.
-	set_transient( 'wp_theme_template_contents_' . $theme->get_stylesheet(), $template_data );
+	set_transient( 'wp_theme_template_contents_' . $theme->get_stylesheet(), $template_data, WEEK_IN_SECONDS );
 
 	return $template_data['template_content'][ $relative_path ];
 }
diff --git a/tests/phpunit/tests/block-template-utils.php b/tests/phpunit/tests/block-template-utils.php
@@ -679,7 +679,8 @@ public function test_get_block_template_file_content_with_current_theme_file_rel
 				'template_content' => array(
 					'parts/small-header.html' => $forced_content,
 				),
-			)
+			),
+			WEEK_IN_SECONDS
 		);
 
 		$content = _get_block_template_file_content( $template_file );
@@ -705,7 +706,8 @@ public function test_get_block_template_file_content_with_another_theme_file_ign
 				'template_content' => array(
 					'templates/page-1.html' => $forced_content,
 				),
-			)
+			),
+			WEEK_IN_SECONDS
 		);
 
 		$content = _get_block_template_file_content( $template_file );
@@ -731,7 +733,8 @@ public function test_get_block_template_file_content_with_current_theme_file_ref
 				'template_content' => array(
 					'parts/small-header.html' => $forced_content,
 				),
-			)
+			),
+			WEEK_IN_SECONDS
 		);
 
 		$content = _get_block_template_file_content( $template_file );
@@ -772,7 +775,8 @@ public function test_get_block_template_file_content_with_current_theme_file_and
 				'template_content' => array(
 					'parts/small-header.html' => $forced_content,
 				),
-			)
+			),
+			WEEK_IN_SECONDS
 		);
 
 		$content = _get_block_template_file_content( $template_file );
@@ -801,7 +805,8 @@ public function test_get_block_template_file_content_with_theme_development_mode
 				'template_content' => array(
 					'parts/small-header.html' => '<div>Some content.</div>',
 				),
-			)
+			),
+			WEEK_IN_SECONDS
 		);
 
 		// We don't care about the value here as it is already covered by the test above.

Original file line number	Diff line number	Diff line change
`@@ -569,7 +569,7 @@ function _get_block_template_file_content( $template_file_path ) {`
`569`	`569`	`$template_data['template_content'][ $relative_path ] = file_get_contents( $template_file_path );`
`570`	`570`
`571`	`571`	`// Update the cache.`
`572`		`- set_transient( 'wp_theme_template_contents_' . $theme->get_stylesheet(), $template_data );`
	`572`	`+ set_transient( 'wp_theme_template_contents_' . $theme->get_stylesheet(), $template_data, WEEK_IN_SECONDS );`
`573`	`573`
`574`	`574`	`return $template_data['template_content'][ $relative_path ];`
`575`	`575`	`}`