General: PHP 7.3 throws an E_WARNING when using continue to target a switch.

SergeyBiryukov · SergeyBiryukov · commit b297a0302008 · 2018-09-24T20:04:56.000Z
Applying continue to a switch is equivalent to using break and quite possibly, a continue targeting a higher level control structure is actually intended. To target the higher level control structure, a numeric argument has to be passed to continue. This fixes two cases in WordPress Core where this is currently happening. See: php/php-src#3364 See: https://wiki.php.net/rfc/continue_on_switch_deprecation Props jrf. Merges [43653] to the 4.9 branch. Fixes #44543. git-svn-id: https://develop.svn.wordpress.org/branches/4.9@43656 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/pomo/plural-forms.php b/src/wp-includes/pomo/plural-forms.php
@@ -207,7 +207,7 @@ protected function parse( $str ) {
 						$span = strspn( $str, self::NUM_CHARS, $pos );
 						$output[] = array( 'value', intval( substr( $str, $pos, $span ) ) );
 						$pos += $span;
-						continue;
+						break;
 					}
 
 					throw new Exception( sprintf( 'Unknown symbol "%s"', $next ) );
diff --git a/tests/phpunit/includes/utils.php b/tests/phpunit/includes/utils.php
@@ -440,7 +440,7 @@ function benchmark_pcre_backtracking( $pattern, $subject, $strategy ) {
 		case PREG_NO_ERROR:
 			return $i;
 		case PREG_BACKTRACK_LIMIT_ERROR:
-			continue;
+			break;
 		case PREG_RECURSION_LIMIT_ERROR:
 			trigger_error('PCRE recursion limit encountered before backtrack limit.');
 			return;

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ protected function parse( $str ) {`
`207`	`207`	`$span = strspn( $str, self::NUM_CHARS, $pos );`
`208`	`208`	`$output[] = array( 'value', intval( substr( $str, $pos, $span ) ) );`
`209`	`209`	`$pos += $span;`
`210`		`- continue;`
	`210`	`+ break;`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`throw new Exception( sprintf( 'Unknown symbol "%s"', $next ) );`