fix(backup-codes): minor UI issues and JS var leak#801
fix(backup-codes): minor UI issues and JS var leak#801masteradhoc merged 1 commit intoWordPress:masterfrom
Conversation
79f3488 to
b817723
Compare
|
|
||
| // Append the codes. | ||
| for ( i = 0; i < response.codes.length; i++ ) { | ||
| for ( var i = 0; i < response.codes.length; i++ ) { |
There was a problem hiding this comment.
This leaked i into the global scope.
| <p id="two-factor-backup-codes"> | ||
| <div id="two-factor-backup-codes"> | ||
| <p class="two-factor-backup-codes-count"> |
There was a problem hiding this comment.
<p> tags cannot be nested; <p> allows only for phrasing content.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
georgestephanis
left a comment
There was a problem hiding this comment.
They all look reasonable and good fixes to me.
What?
This pull request updates the markup structure and JavaScript in the backup codes provider to fix HTML issues. It also updates related tests to match these changes.
Markup improvements:
user_optionsfrom a<p>to a<div>because it is illegal to nest<p>tags.JavaScript update:
ivariable into the global scope.Test updates:
Why?
Correctness and maintainability.
How?
<p>tags, replaced the outermost<p>with a<div>;Testing Instructions
CI must pass - I have updated the tests.
Screenshots or screencast
N/A
Changelog Entry