Merged
Conversation
Collaborator
Author
|
@cameronjonesweb, @ccoley Could you please do a code review and test if this resolves both #256 and #257? |
|
Can confirm this resolves #256. Great job, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256 and #257.
Hardcodes the two-factor form action URL to
wp-login.php(similar to WP core) since all of the two-factor processing relies onlogin_form_{$action}hooks.Lots of WPCS fixes related to this simple change and the surrounding form HTML.
Tested that this doesn't introduce regression with custom login forms outside
wp-login.php, such as WooCommerce.