This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Closed
Conversation
Member
Author
|
Also see WordPress/gutenberg#35591 in the Gutenberg repo regarding implementing the |
aristath
commented
Oct 13, 2021
8f75cd3 to
4a88f70
Compare
Member
Author
|
Once the core patch gets merged and we have an implementation in Gutenberg for theme.json, we should add the below in "webfonts": [
{
"fontFamily": "Source Serif Pro",
"fontWeight": "200 900",
"fontStyle": "normal",
"fontStretch": "normal",
"src": "file:./assets/fonts/source-serif-pro/SourceSerif4Variable-Roman.ttf.woff2",
"provider":"local"
},
{
"fontFamily": "Source Serif Pro",
"fontWeight": "200 900",
"fontStyle": "italic",
"fontStretch": "normal",
"src": "file:./assets/fonts/source-serif-pro/SourceSerif4Variable-Italic.ttf.woff2",
"provider":"local"
}
] |
4a88f70 to
7f562c5
Compare
Collaborator
|
I'm going to close this one for now, since it's outdated and the corresponding PR isn't going to be a part of 5.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WordPress/wordpress-develop#1736 we're working on a webfonts API for WordPress Core.
This PR is a companion to the core patch, to test the API.
Eventually, the goal is to have webfonts defined in the
theme.jsonfile, but in this 1st iteration we're using awp_register_webfontsfunction.