This repository was archived by the owner on Oct 28, 2022. It is now read-only.
Adding Style Variation Sherbet #104#161
Closed
Dabalina wants to merge 5 commits intoWordPress:trunkfrom
Closed
Conversation
added 5 commits
September 11, 2022 11:33
… of typography from 700 to 500, changed default typography to inter
10 tasks
Collaborator
|
If we want to the duotone to work in the same way as Retroactive we'd need to explicitly set the filters for the each of the blocks that it would apply to. |
Member
|
Thanks for working on this! ❤️ I've opened a PR to move the Inter font definition to the base theme, so we don't need to include the font in this variation. |
mikachan
reviewed
Sep 18, 2022
Member
mikachan
left a comment
There was a problem hiding this comment.
Looking good! I've just left two small comments.
| { | ||
| "$schema": "https://schemas.wp.org/trunk/theme.json", | ||
| "version": 2, | ||
| "title": "Variation Sherbet", |
Member
There was a problem hiding this comment.
The title should just be, "Sherbet".
| ] | ||
| }, | ||
| "typography": { | ||
| "fontFamilies": [ |
Member
There was a problem hiding this comment.
We don't need to redefine the font families in the variation file, so we can remove the 'fontFamilies' array.
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Sherbet style variation with suggested changes. There is a suggestion to add a duotone like the one in retroactive, I went ahead and added the same duotone from retroactive, wondering if it should be a bit different but not sure what to do with it.
Fixes #104