This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Merged
Conversation
Closed
e85899e to
c2a9774
Compare
Collaborator
|
Hey @melchoyce thank you for this. I rebased the PR and updated the colors, but the spacings seem kind off to me after we changed the global values. Can you have another look at it? |
Collaborator
|
oh, I will add translations to the strings too |
Merged
Member
|
I've updated the spacings on this one with the latest version of trunk. |
MaggieCabrera
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried replicating this pattern as closely as possible:
Figma
Some issues I ran into:
These issues are related to #34 and #49