Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Add "posts" pattern#86

Merged
MaggieCabrera merged 6 commits intotrunkfrom
add/pattern/posts
Sep 6, 2023
Merged

Add "posts" pattern#86
MaggieCabrera merged 6 commits intotrunkfrom
add/pattern/posts

Conversation

@melchoyce
Copy link
Copy Markdown
Contributor

Tried replicating this pattern as closely as possible:

image
Figma

Some issues I ran into:

  • The spacing presets don't match the space in the mockup.
    • The preset I used for spacing between columns, block title, and post title is 36px, but the spacing in Figma is 32px
    • The preset I used for spacing between meta is off; there's not a great way to measure this since it's formatted as a single paragraph, but I'm using a row block to get all of the information in one line
  • The font size presets didn't match the mockup (I used custom sizing for the heading since the presets were way off, and the "small" size for the excerpt because it was only 1px off)
  • I couldn't easily add "by" before the author name without it being a separate block

These issues are related to #34 and #49

@juanfra juanfra linked an issue Aug 29, 2023 that may be closed by this pull request
@MaggieCabrera
Copy link
Copy Markdown
Collaborator

Hey @melchoyce thank you for this. I rebased the PR and updated the colors, but the spacings seem kind off to me after we changed the global values. Can you have another look at it?

@MaggieCabrera
Copy link
Copy Markdown
Collaborator

oh, I will add translations to the strings too

@MaggieCabrera MaggieCabrera mentioned this pull request Sep 4, 2023
@luminuu
Copy link
Copy Markdown
Member

luminuu commented Sep 5, 2023

I've updated the spacings on this one with the latest version of trunk.

@MaggieCabrera MaggieCabrera merged commit 88d7667 into trunk Sep 6, 2023
@luminuu luminuu deleted the add/pattern/posts branch September 12, 2023 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block Patterns - Posts

4 participants