Create project-layout.php#183
Conversation
| <!-- /wp:image --> | ||
|
|
||
| <!-- wp:paragraph {"style":{"typography":{"fontSize":"0.8rem"}}} --> | ||
| <p style="font-size:0.8rem"><?php echo esc_html__( "1. Queste basi mi hanno permesso di affrontare la sessione con un profondo apprezzamento per l'identità dell'hotel e una chiara visione della storia che volevo raccontare attraverso il mio obiettivo.", 'twentytwentyfour' ); ?></p> |
There was a problem hiding this comment.
I think the text here shouldn't have the 1. at the start
There was a problem hiding this comment.
The 1 is inside the new version on figma, shoud i delete it?
There was a problem hiding this comment.
Sorry, I didn't see the new style on figma, I had to refresh my browser. It's fine to keep, but let's change the function to use esc_html_x and explain what this text is referring to. I would love if we could use the image caption for this, but I'm not sure that we can while maintaining the design
There was a problem hiding this comment.
Yeah i thought about the caption but i think that without some custom css is impossible to have the same design of Figma.
Yeah, i'll use the esc_html_x thank u.
| /** | ||
| * Title: Project Layout | ||
| * Slug: twentytwentyfour/project-layout | ||
| * Categories: text |
There was a problem hiding this comment.
let's add gallery to the list here
There was a problem hiding this comment.
Ok, perfect. i didn't think about that ahah sorry.
|
|
||
| ?> | ||
|
|
||
| <!-- wp:group {"style":{"spacing":{"padding":{"top":"6vw","right":"6vw","bottom":"6vw","left":"6vw"}},"elements":{"link":{"color":{"text":"#fffffffc"}}},"color":{"background":"#181818","text":"#fffffffc"}},"layout":{"type":"constrained"}} --> |
There was a problem hiding this comment.
This should have wide width. The colors should use the presets from the theme instead of the hex values and the spacing should also try to use the presets too
There was a problem hiding this comment.
Thanks for all your help. I not founded the preset color, so i thought wasn't so important inside the all theme (i'll fix it).
How can i achive to use the preset for the spacing if not using the block spacing?
Again, thanks for all your help
There was a problem hiding this comment.
This is where you use the presets:
There was a problem hiding this comment.
I think now is ok. Only a little question. There's no the same color of the background (based on figma file) i used the contrast color preset, is ok or i have to create the preset myself into the theme.json?)
Sorry for all the extra work i make you do...i'm trying to learn fastest possible for make no errors.
There was a problem hiding this comment.
it's absolutely no issue! and thank you for following up on our reviews, that's what we are here for. You shouldn't need to create any presets, but chose what looks closer to the design. We have iterated away from some of the color to make them more accesible.
There was a problem hiding this comment.
Thank u very much for the kind words.
Ok, i choosed the contrast color preset, the #222222 hope is ok for the pattern.
Used esc_html_x function Added gallery category Used preset for padding and colors (the bg color is not the same of the figma file because there's no preset like that color)
9dcb262 to
3d30963
Compare
MaggieCabrera
left a comment
There was a problem hiding this comment.
I made a few changes to this one and rebased it. Changed the language to use the english version so it fits with the rest of the full page pattern, as well as the images so they make sense with the text changes too. I converted the images to webp and tweaked the markup to use presets where it wasn't using them
Thanks for all your help. I'll see the edit u made so i'll make better the next time. |
Sorry first time contributing, hope i'm doing ok.
Add Project Layout
Description
Add the project layout pattern