Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Improve "Preview Theme Changes" GitHub Actions workflow#652

Closed
tfrommen wants to merge 1 commit intoWordPress:trunkfrom
tfrommen:patch-1
Closed

Improve "Preview Theme Changes" GitHub Actions workflow#652
tfrommen wants to merge 1 commit intoWordPress:trunkfrom
tfrommen:patch-1

Conversation

@tfrommen
Copy link
Copy Markdown
Member

@tfrommen tfrommen commented Oct 28, 2024

This quick PR includes some general improvements for the preview workflow:

  • Start with no permissions, then grant required permissions on job level.
  • Specify timeout.
  • Upgrade checkout action.
  • Formatting.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 28, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tfrommen <tfrommen@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Copy Markdown
Contributor

carolinan commented Oct 29, 2024

Hi
Since this repository is going to be archived, I don't think there is any reason to update this.
The bundled themes are only built on GitHub until release. Normally, this archive would have been closed at RC1.

@carolinan carolinan closed this Nov 15, 2024
@tfrommen tfrommen deleted the patch-1 branch November 15, 2024 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tfrommen @carolinan