Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Rename primary/secondary/opacity colors to accents#420

Merged
carolinan merged 1 commit intoWordPress:trunkfrom
EvanHerman:update-accent-colors
Sep 27, 2024
Merged

Rename primary/secondary/opacity colors to accents#420
carolinan merged 1 commit intoWordPress:trunkfrom
EvanHerman:update-accent-colors

Conversation

@EvanHerman
Copy link
Copy Markdown
Contributor

@EvanHerman EvanHerman commented Sep 25, 2024

Resolves #415

Description

As mentioned in the original issue, it is not clear what significance the Primary, Secondary and Opacity colors have and should actually be accent colors. This PR changes the Primary color to Accent 4, Secondary to Accent 5 and Opacity to Accent 6.

Screenshots

image image image

Testing Instructions

  • Edit the global styles.
  • Click on 'Palette'.
  • Hover over each color to see their name appear in a tooltip.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 25, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 25, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: EvanHerman <eherman24@git.wordpress.org>
Co-authored-by: richtabor <richtabor@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jasmussen jasmussen mentioned this pull request Sep 26, 2024
Closed
@richtabor
Copy link
Copy Markdown
Member

richtabor commented Sep 26, 2024

@EvanHerman we'll need to do the same in the style variations within /styles/*

@carolinan carolinan merged commit 182785d into WordPress:trunk Sep 27, 2024
@carolinan carolinan mentioned this pull request Sep 27, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change primary and secondary color slugs to "accent" colors

3 participants

@EvanHerman @richtabor @carolinan