Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Add - about FAQs pattern#267

Merged
juanfra merged 5 commits intoWordPress:trunkfrom
tanvirulhaque:add/about-faqs-pattern
Sep 11, 2024
Merged

Add - about FAQs pattern#267
juanfra merged 5 commits intoWordPress:trunkfrom
tanvirulhaque:add/about-faqs-pattern

Conversation

@tanvirulhaque
Copy link
Contributor

@tanvirulhaque tanvirulhaque commented Sep 11, 2024

Description

Adds Block Patterns - About FAQs #67

Screenshots
Screenshot 2024-09-11 at 1 38 11 PM

Testing Instructions

  1. Create a page.
  2. Add the pattern.
  3. Test that the pattern looks like the design.

@github-actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tanvirulhaque <tanvirul@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: iamsam2e <samtoohey93@git.wordpress.org>
Co-authored-by: beafialho <beafialho@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra linked an issue Sep 11, 2024 that may be closed by this pull request
Block Patterns - About - FAQs #67
Closed
juanfra
juanfra reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this! The implementation looks well. I left a few comments for you to address.

The other thing I'd like to ask you is if you can wrap the pattern in a group that has full-width. That way users, will be able to select the variation for the pattern and it will look in line with the other patterns (taking full width). Please ensure that you set the margin to zero for that group. Thanks

Screen.Recording.2024-09-11.at.09.51.45.mov

juanfra
juanfra reviewed Sep 11, 2024
View reviewed changes
@tanvirulhaque
Copy link
Contributor Author

tanvirulhaque commented Sep 11, 2024

Hi @juanfra thanks for your quick review :) I have updated with the fix, could you take a look?

juanfra
juanfra approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this @tanvirulhaque

The code is looking good to me, and it is also looking good ✨

Screen.Recording.2024-09-11.at.10.43.3011.mov

@juanfra juanfra merged commit 6e4eb02 into WordPress:trunk Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@juanfra juanfra juanfra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tanvirulhaque tanvirulhaque

Labels

[Component] Block Patterns

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Block Patterns - About - FAQs

2 participants

@tanvirulhaque @juanfra