This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Fixes for the Columns block#967
Merged
pattonwebz merged 4 commits intoNov 10, 2019
Merged
Conversation
…and prevent issues with uneven horizontal paddings within columns that have a mix of elements that include paragraphs
Contributor
|
@yannickiki Do you have time to test this? :) |
carolinan
approved these changes
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for the Columns block issues created by @yannickiki earlier today.
Fixes #963 and #961 by removing the paragraph-only padding used for the first and last columns in full-width columns blocks previously, and replaces it with a horizontal padding on the block as a whole. This made it possible to reduce the amount of CSS quite a bit, since it removed the need for different solutions for different breakpoints.
Fixes #960 by adjusting the spacing between stacked Columns blocks between
782pxand999px. Also tweaked the margin on desktop, to make the horizontal margin between stacked columns blocks32px(same as the gutter) on all screen sizes.