Empty Theme: Script to generate a personalized starter theme#95
Empty Theme: Script to generate a personalized starter theme#95MaggieCabrera merged 10 commits intoadd/empty-themefrom
Conversation
jffng
left a comment
There was a problem hiding this comment.
Looking good and working well for me!
We should add some documentation to the readme about the php requirement and how to use this.
|
Is it more convenient for this to generate a zip or a directory? |
I am not 100% sure of how we want to go with this script and that's why I kept the approach of the underscores original code. And also why I didn't add any extra info for the style.css. I think this is a good starting point and the next steps would be:
Does that sound good? Anything else we could add? |
|
So happy to see work on this starting 🎉 |
|
This is ready for another review :D |
|
In style.css I still see this:
|
|
The block template parts also have the theme slug in them. |
I think the theme slug should be removed from the template parts like Jorge says here: #81 (comment) |
|
🎉 Thanks for this, @MaggieCabrera! |
Using https://github.com/Automattic/underscores.me/blob/master/plugins/underscoresme-generator/underscoresme-generator.php as a reference I created a script that will generate a zip file with a theme based on
emptythemethat has the name the user gives to the script.Run
php new-empty-theme.phpfrom the root of the repo.We can expand on this to add further info for style.css such as Author, Description, etc. I only did the name as a starting point.