Update CI test matrix and fix PHPUnit security advisory failure#2
Conversation
…WordPress compatibility
… PHPUnit compatibility
| - php: "8.4" | ||
| wp: "latest" | ||
| experimental: false | ||
| # Lowest supported: PHP 7.4 + oldest WP. |
There was a problem hiding this comment.
I am not completely sure why this was made. The WordPress importer, like all the other standard ones, supports down to WP 5.4 and WordPress down to PHP 7.2. To fix GHSA-vvj3-c3rp-c85p unit tests failing? If that's the only reason, it's ok.
But please make these two changes on https://github.com/WordPress/substack-importer/blob/trunk/readme.txt:
- Tested up to
6.9 - Require PHP:
7.4
A new version for these only changes is not needed. At the next one please add this line:
= x.y.z =
1. Compatibility: the plugin now requires PHP 7.4 or higher.There was a problem hiding this comment.
Yes, it was to fix the unit tests failing in GHSA-vvj3-c3rp-c85p. PHPUnit ^9.6 is now used, which has the issue fixed. I can probably add continue-on-error: true for older versions and use a lower PHPUnit, but I figured that it's okay like this. Let me know if I should do it that way, and I'll fix it in another PR.
Changes proposed in this Pull Request
PKSA-z3gr-8qht-p93v(CVE-2026-24765). Pinphpunit/phpunitto^9.6which resolves to 9.6.34 - a patched version outside the advisory's affected rangeyoast/phpunit-polyfillsfrom^1.0.1to^2.0.ramsey/composer-installstep withdependency-versions: highestnow handles all matrix entries.composer requirestep (packages already incomposer.json), upgrade PHP from 7.4 to 8.3, update action versions, and fixcs2prXML parsing by adding the-qflag.trunkand on pull requests (previously ran on all pushes to any branch).phpunit.xml.distto remove deprecated PHPUnit 10-incompatible attributes (convertErrorsToExceptions,convertNoticesToExceptions,convertWarningsToExceptions).Testing instructions
composer installresolves locally without errors or security advisory warnings.