Add toggle to SQLite Admin Bar item display via PHP filter hook#89
Closed
0aveRyan wants to merge 2 commits intoWordPress:mainfrom
0aveRyan:add/adminbar-visibility-toggle-hook
Closed
Add toggle to SQLite Admin Bar item display via PHP filter hook#890aveRyan wants to merge 2 commits intoWordPress:mainfrom 0aveRyan:add/adminbar-visibility-toggle-hook
0aveRyan wants to merge 2 commits intoWordPress:mainfrom
0aveRyan:add/adminbar-visibility-toggle-hook
Conversation
Collaborator
|
@0aveRyan couldn't you achieve the same with this code? remove_action( 'admin_bar_menu', 'sqlite_plugin_adminbar_item' ); |
Author
|
You sure could 😁 well, we can close this. If I use a custom color scheme soon and the hardcoded green bugs me I may come back for it 😅 |
Author
|
On mobile, but pulled this out of my link graveyard and set a reminder. One of these CSS classes is probably right for the text. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the goal should always be to surface the SQLite database state transparently, however that should be balanced with providing a WordPress experience that feels native, doesn't have excess clutter in screenshots, etc.
The current implementation's UX could either use a little refinement or relocation.
As the SQLite state is surfaced in the database, I think this proposed filter and/or...