Skip to content

Check for discouraged functions#941

Merged
davidperezgar merged 5 commits intotrunkfrom
909-plugin-textdomain
May 21, 2025
Merged

Check for discouraged functions#941
davidperezgar merged 5 commits intotrunkfrom
909-plugin-textdomain

Conversation

@ernilambar
Copy link
Copy Markdown
Member

@ernilambar ernilambar commented May 13, 2025 •
edited
Loading

Fixes #909

@ernilambar ernilambar force-pushed the 909-plugin-textdomain branch from 36ba232 to 8488b01 Compare May 13, 2025 09:51
@ernilambar ernilambar force-pushed the 909-plugin-textdomain branch from 8488b01 to 6c38427 Compare May 13, 2025 09:54
@ernilambar ernilambar marked this pull request as ready for review May 13, 2025 09:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 13, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added this to the 1.6.0 milestone May 13, 2025
@ernilambar ernilambar added [Type] Check Proposal A new check proposal [Team] Plugins Issues owned by Plugins Team labels May 13, 2025
@ernilambar ernilambar force-pushed the 909-plugin-textdomain branch 3 times, most recently from b1c6ca7 to 7fd69aa Compare May 13, 2025 11:39
@ernilambar ernilambar force-pushed the 909-plugin-textdomain branch from 7fd69aa to c1a8996 Compare May 13, 2025 11:42
davidperezgar
davidperezgar reviewed May 15, 2025
View reviewed changes
swissspidy
swissspidy approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If y'all think the error message will be clear enough for developers / there is solid documentation, then this looks good.

@ernilambar ernilambar requested a review from chriscct7 as a code owner May 16, 2025 09:04
@ernilambar ernilambar force-pushed the 909-plugin-textdomain branch from 9800017 to d5f6ac9 Compare May 16, 2025 09:06
@ernilambar ernilambar requested a review from davidperezgar May 20, 2025 06:31
@davidperezgar davidperezgar merged commit 1551259 into trunk May 21, 2025
26 checks passed
@davidperezgar davidperezgar deleted the 909-plugin-textdomain branch May 21, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@davidperezgar davidperezgar davidperezgar approved these changes

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

Assignees

No one assigned

Labels

[Team] Plugins Issues owned by Plugins Team [Type] Check Proposal A new check proposal

Projects

None yet

Milestone

1.6.0

Development

Successfully merging this pull request may close these issues.

Check: Using load_plugin_textdomain() for loading the plugin translations is not needed for WordPress.org directory since WordPress 4.6

3 participants

@ernilambar @swissspidy @davidperezgar