Skip to content

When checking for excluded files, use the normalized path to ensure that it works in Windows environments.#694

Merged
swissspidy merged 4 commits intoWordPress:trunkfrom
pbiron:cli-exclude-files-windows
Oct 23, 2024
Merged

When checking for excluded files, use the normalized path to ensure that it works in Windows environments.#694
swissspidy merged 4 commits intoWordPress:trunkfrom
pbiron:cli-exclude-files-windows

Conversation

@pbiron
Copy link
Copy Markdown
Contributor

@pbiron pbiron commented Oct 3, 2024

Fixes #693

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pbiron <pbiron@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: ernilambar <rabmalin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

…iles().

This probably should have been removed in WordPress#592, but was forgotten.
@pbiron
Copy link
Copy Markdown
Contributor Author

pbiron commented Oct 8, 2024

@davidperezgar can you please look at this PR before v1.2.0 ships?

@davidperezgar
Copy link
Copy Markdown
Member

I don't know for sure, we're in final stages of version.

@pbiron
Copy link
Copy Markdown
Contributor Author

pbiron commented Oct 8, 2024

the reason I would really like to get it into 1.2.0 is that it is a follow-up to #592 which will be included in 1.2.0. #592 fixed one prob for the WP_CLI command in Windows but missed another one.

@swissspidy swissspidy added this to the 1.3.0 milestone Oct 11, 2024
@ernilambar
Copy link
Copy Markdown
Member

I don't have Windows setup to test the PR. Can someone please verify who is in Windows OS?

@swissspidy
Copy link
Copy Markdown
Member

I trust that @pbiron did the necessary testing when fixing this bug on their machine :)

@swissspidy swissspidy merged commit 341b335 into WordPress:trunk Oct 23, 2024
@pbiron pbiron deleted the cli-exclude-files-windows branch October 23, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: ensure --exclude-files works in Windows

4 participants