Skip to content

Feature, add support for .distignore #692

@angelomandato

Description

@angelomandato

I would like to add support for GitHub's .distignore, if the file is found then those files in this file are ignored for the hidden_files check. I can gladly create a pull request but before I do I wanted to seek support from the rest of the committers.

There are 2 approaches, use a define that would be placed in the wp-config.php or make it a checkbox option before every scan.

Note: The plugin's current behavior should not use the .distignore I am proposing above by default, but only use it if a define or check option is set. I am suggesting this as an option for developers who develop locally that are aware their distribution used on the WordPress plugin SVN will not have these dot hidden files.

Define option to enable this option:

define('WP_PLUGIN_CHECK_USE_DISTIGNORE', true);

This way the current behavior remains, but for developers who setup a dev environment using this plugin who know that their releases will not have the hidden files can add the define to their wp-config.php.

Checkbox option to enable this option:
The other approach is to add this as a checkbox option before performing a scan. This is equally acceptable, but if an option like this is too easy the developer may not understand the consequences if those hidden files end up in the distributed plugin. Maybe the option could be on the screen but hidden under a separate section that is titled "Advanced Options" and is only exposed when they click on a "show advanced options" button.

Thanks everyone for an awesome plugin!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Needs DiscussionAnything that needs a discussion/agreement[Type] EnhancementA suggestion for improvement of an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions