Add express to dependencies; Update follow-redirects to newest version#225
Conversation
|
@eliot-akira , thanks for this PR.
If you pull the latest changes from trunk, the tests should pass. |
…into add-express-to-dependencies
|
OK, merged from trunk, ran I suppose this PR can be merged before the other one (WordPress/wordpress-playground#1218), since that removes the As an aside, recently I'm integrating |
@eliot-akira YAY! I'm so glad to hear that! Personally I've ran into some rough edges with modes and auto-mounting things and would love to make that optional and configurable via CLI options. But other than it did the trick on my end, too. I think you'd like Studio – @sejas could give you early access. |
|
Studio looks cool! From the screenshot I imagine a desktop app for managing local WordPress sites powered by Playground. Curious to try it, I signed up for the waitlist. I'm still solving a few things to completely replace
|
|
@eliot-akira for mapping, let's explore that in Blueprints v2: |
What?
This is the second part of solving:
The first part is WordPress/wordpress-playground#1218. (php-wasm/node: Update express to newest version, and move it to devDependencies)
Why?
The first part of the solution is in the Playground project, which updates
expressand moves it todevDependenciessince it's only used for tests in that project.As a result,
expresswill no longer be installed when@php-wasm/nodeis installed. Sowp-nowneeds to declareexpressas a dependency.How?
expresstodependenciesfollow-redirectsto newest1.15.6These together with WordPress/wordpress-playground#1218 will resolve the original issue #224, which should eliminate all npm audit warnings.
Testing Instructions
Currently
npm run testfails with an unrelated issue, as can be seen in another PR's CI test run. https://github.com/WordPress/playground-tools/actions/runs/8616282863/job/23614052137?pr=223#step:4:49 ("RuntimeError: memory access out of bounds") That seems have been caused by commit 133029c.