Skip to content

Implement proper Google provider using its first-class API #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JasonTheAdams merged 11 commits into from
Dec 30, 2025
Merged

Implement proper Google provider using its first-class API #155

JasonTheAdams merged 11 commits into from
Dec 30, 2025

Conversation

@felixarntz
Copy link
Member

@felixarntz felixarntz commented Dec 30, 2025

Fixes #106

Replaces #152 (which was accidentally using the protected feature/* branch prefix)

@felixarntz felixarntz added this to the 0.4.0 milestone Dec 30, 2025
@felixarntz felixarntz added the [Feature] New feature to highlight in changelogs. label Dec 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 30, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: JasonTheAdams <jason_the_adams@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz
Copy link
Member Author

felixarntz commented Dec 30, 2025

@JasonTheAdams Can you please add #152 (comment) here?

@felixarntz
Copy link
Member Author

felixarntz commented Dec 30, 2025

@JasonTheAdams 638a0ac addresses your feedback in #152 (comment). The same wording was already present in several other places, so I updated it everywhere.

@felixarntz
Copy link
Member Author

felixarntz commented Dec 30, 2025

@JasonTheAdams Can you please give this a re-review so we can get it merged? No changes compared to #152, other than the extra commit above.

JasonTheAdams
JasonTheAdams approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@JasonTheAdams JasonTheAdams left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM! 🚀

I did push my typing refactor, so let me know if you have any thoughts on that before we merge.

@JasonTheAdams JasonTheAdams merged commit d262f29 into trunk Dec 30, 2025
6 checks passed
@JasonTheAdams JasonTheAdams deleted the add/proper-google-provider-implementation branch December 30, 2025 18:47
@felixarntz felixarntz mentioned this pull request Dec 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonTheAdams JasonTheAdams JasonTheAdams approved these changes

Assignees

No one assigned

Labels

[Feature] New feature to highlight in changelogs.

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

Use Google's primary Gemini API endpoints instead of its OpenAI compatibility layer

3 participants

@felixarntz @JasonTheAdams