-
Notifications
You must be signed in to change notification settings - Fork 43
Fix getProviderClassName() return type
#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@JasonTheAdams There's some weird PHPStan issue when I change it, see https://github.com/WordPress/php-ai-client/actions/runs/20122278394/job/57744921021?pr=147: I don't see why it complains about the value being a string here. As far as I can tell, the type annotations for the underlying class properties correctly use |
|
@felixarntz check out 30b3ffd So the issue is that we're have a union Fortunately, PHPStan has |
JasonTheAdams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, but you should as well, @felixarntz, since I ended up changing more code than you. Hahah!
felixarntz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JasonTheAdams Awesome! Really appreciate learning more gotchas about PHPStan from you :)
No description provided.