Add image regeneration module#496
Add image regeneration module#496felixarntz merged 5 commits intofeature/regenerate-existing-imagesfrom
Conversation
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Left one minor review.
| return function() { | ||
| return true; | ||
| }; |
There was a problem hiding this comment.
It should be like below?
| return function() { | |
| return true; | |
| }; | |
| return '__return_true'; |
There was a problem hiding this comment.
@mukeshpanchal27 True value is temporary and will be replaced by appropriate condition eventually. Also, this snippet will load the module if the returned value is not callable, so I think we will save calling an extra function which eventually returns true which we are already returning.
Please let me know your opinion.
There was a problem hiding this comment.
Similar to my comment in #489, I'd argue we don't even need this file right now. We can add it later if we ever want to add custom logic to determine whether the module can load or not.
felixarntz
left a comment
There was a problem hiding this comment.
@ankitrox Two minor comments below, and one more here: Can you please also add this module to the CODEOWNERS file, similar to the other image modules? For now maybe add @jjgrainger and yourself as owners if that works for you?
| return function() { | ||
| return true; | ||
| }; |
There was a problem hiding this comment.
Similar to my comment in #489, I'd argue we don't even need this file right now. We can add it later if we ever want to add custom logic to determine whether the module can load or not.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
felixarntz
left a comment
There was a problem hiding this comment.
Great, thank you @ankitrox!
Summary
This PR adds the
regenerate-existing-imagesmodule in the plugin. This shall be the first thing to get merged for image regeneration work.All of the subsequent work related to image regeneration would reside in this module.
Fixes #489
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.