Use WP_HTML_Tag_Processor::set_modifiable_text in Optimization_Detective_Test_Helpers#2511
Conversation
…ive_Test_Helpers.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2511 +/- ##
=======================================
Coverage 69.29% 69.29%
=======================================
Files 90 90
Lines 7723 7723
=======================================
Hits 5352 5352
Misses 2371 2371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, I forced pushed a similar commit as your previous one... |
Summary
See #2354
Relevant technical choices
Use
WP_HTML_Tag_Processor::set_modifiable_textinOptimization_Detective_Test_Helpersas requested in the issue.Note that I didn't used
assertEqualHTMLsince WP 6.6 seems to be the lowest tested version in GitHub workflow.Drop WP 6.6 from tests matrix in favor of WP 6.7.
Use of AI Tools
I helped myself with Cursor.