This repository was archived by the owner on Jul 9, 2018. It is now read-only.
Conversation
adamsilverstein
approved these changes
Dec 21, 2017
Member
adamsilverstein
left a comment
There was a problem hiding this comment.
Looks good. Removing --hoist seems fine especially if it was causing issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Lerna and Jest to the latest version. In addition, it regenerates
package-lock.jsonto use the latest versions of other packages.I removed also
--hoistoption for Lerna. It looks like we aren't sharing the same packages inside Lerna packages, so it doesn't make too much sense to keep it. It caused some issues when working on #55.Gruntcomplained because it didn't have locally referenced Grunt dependencies. In addition I didn't see this flag used in other repositories structured with Lerna like Jest or create-react-app.