This repository was archived by the owner on Jul 9, 2018. It is now read-only.
is-shallow-equal: Fall back to strict equality for non-object-like#116
Merged
is-shallow-equal: Fall back to strict equality for non-object-like#116
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 67.39% 67.34% -0.05%
==========================================
Files 56 56
Lines 690 689 -1
Branches 142 143 +1
==========================================
- Hits 465 464 -1
Misses 183 183
Partials 42 42
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue / enhance behavior of
isShallowEqualto account for cases where the arguments passed are not strictly object-like (arrays or objects). In particular, this is useful in cases where one of the two arguments may beundefined.Implementation notes:
Included are some assorted general refactorings. After poring endlessly over benchmark results on trivial details, I've deemphasized "winning". The latest benchmarks still have the included implementation as the most performant option, though I have found these results to vary unexpectedly.
Testing instructions:
Ensure unit tests pass: