Code Editor: unselect blocks and disable inserter#9815
Conversation
tofumatt
left a comment
There was a problem hiding this comment.
I dig it. Tested locally and it was nice.
Seems a good contender for an e2e test or two. If you want to add them now I'm happy to review again, otherwise could you file an issue? 😄
| <FullscreenModeClose /> | ||
| <div> | ||
| <Inserter position="bottom right" /> | ||
| <Inserter disabled={ mode !== 'visual' } position="bottom right" /> |
There was a problem hiding this comment.
These sorts of magic constants always irk me, even when they're strings. This is pretty obvious in its intent, but it's still possible to make typos, etc. 🤷♂️
Not really isolated to this PR though.
|
Yep! Ship it. This works well. |
|
@tofumatt Test added if you want to take another look. |
test/e2e/specs/code-editor.test.js
Outdated
There was a problem hiding this comment.
We have an editor-modes.test.js that this might fit into better, up to you though. Our test names are odd 🤷♂️
test/e2e/specs/code-editor.test.js
Outdated
… inserter disabled
75bdcf9 to
306ba2e
Compare
|
Yay, less is more! I'm glad we took this route to fix the parent issue. |
closes #9807
This PR does two things: