Components: Separate button and link components#9702
Closed
Conversation
4 tasks
Member
|
The principle of this design wise makes sense so removing the feedback label. |
Member
Author
|
With 5.0 having shipped and serving as a basis for committing to backwards-compatibility, it's not seeming as viable to me to make such a fundamental shift to how we treat buttons and links in the WordPress components. Furthermore, the drift between this branch and master makes it challenging to resolve existing conflicts. Moving forward, I've heard some commentary (citation needed) about at least flattening some of the variations of these components, including IconButton, ExternalLink, etc. I think it's worthwhile to keep open #7534, where discussion can continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7534
Work In Progress: This is an early iteration which includes basic refactoring, opened here for initial feedback as some of the proposals explored here and in #7534 are potentially subject to debate.
This pull request seeks to:
Buttonto a newLinkcomponentButton'shrefandtargetprops have been deprecatedisDefaultpropisBorderlessandisUnstyled, respectively to varying degrees of style resetsButtonandLinkcan interchangeably inherit the appearance of another, viahasLinkAppearanceandhasButtonAppearancerespectively.ButtonsisLinkprop has been deprecated. The new prop name is intended to better reflect that this is a cosmetic appearance change, not a change in semantics.Buttoncomponent stylesheet to_mixins.scss