Rename the AccessibleSVG component just Svg#9656
Closed
youknowriad wants to merge 1 commit intomasterfrom
Closed
Conversation
gziolo
reviewed
Sep 6, 2018
| @@ -1,7 +1,7 @@ | |||
| // Components | |||
| export * from './primitives'; | |||
Member
There was a problem hiding this comment.
This thing overrides Svg from primitives now :)
We need to find out what would be the best strategy for maintaining Svg to make it work for both web and mobile (RN).
Contributor
Author
There was a problem hiding this comment.
yes, maybe let's keep it as AccessibleSVG for now.
Contributor
Author
|
Closing, let's rediscuss this. |
Member
Where will this be discussed? |
Member
|
#9294 should be the place for start |
5 tasks
Member
|
I proposed an alternative approach in #9685. To make it work with React Native platform, I want to overload
This would be applied only to the RN version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #9565 (comment)
All of our components should be accessible SVG so there's no point in adding Accessible in the name.