Add basic tests for Panel Component.#933
Merged
BE-Webdesign merged 2 commits intomasterfrom May 30, 2017
Merged
Conversation
Closed
nylen
approved these changes
May 30, 2017
nylen
reviewed
May 30, 2017
components/panel/test/body.js
Outdated
| expect( panelBody.instance().state.opened ).to.be.true(); | ||
| } ); | ||
|
|
||
| it( 'with intialOpen set to false', () => { |
nylen
reviewed
May 30, 2017
components/panel/test/body.js
Outdated
| expect( panelBody.instance().state.opened ).to.be.false(); | ||
| } ); | ||
|
|
||
| it( 'with intialOpen set to false', () => { |
Contributor
Author
There was a problem hiding this comment.
good 👀, I will cycle back to these.
Adds basic Panel component tests. Related to progress on #641. Covers the Panel, PanelHeader, and PanelBody components. Testing Instructions Run npm i && npm run test-unit ensure tests pass. Change component logic to ensure tests fail as they should.
d73ae72 to
33b00fc
Compare
33b00fc to
ed5c94a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic Panel component tests. Related to progress on #641. Covers
the Panel, PanelHeader, and PanelBody components.
Testing Instructions
Run npm i && npm run test-unit ensure tests pass. Change component logic
to ensure tests fail as they should.