Adds basic IconButton component tests.#932
Merged
BE-Webdesign merged 2 commits intomasterfrom May 30, 2017
Merged
Conversation
Closed
nylen
reviewed
May 30, 2017
components/icon-button/test/index.js
Outdated
| expect( iconButton.prop( 'aria-label' ) ).to.equal( 'WordPress' ); | ||
| } ); | ||
|
|
||
| it( 'with additonal className', () => { |
Member
There was a problem hiding this comment.
Typo here and below: addditonal → additional
nylen
approved these changes
May 30, 2017
Member
nylen
left a comment
There was a problem hiding this comment.
In general I think we should just merge these, it's great to have the tests and we can always add more later.
Contributor
|
Really great work on all these tests @BE-Webdesign 👍 |
Adds basic IconButton component tests. Related to progress on #641. Testing Instructions Run npm i && npm run test-unit ensure tests pass. Change Dashicon logic to ensure tests fail as they should.
6c8f546 to
3ff6c5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic IconButton component tests. Related to progress on #641.
Testing Instructions
Run npm i && npm run test-unit ensure tests pass. Change Dashicon logic
to ensure tests fail as they should.