Templates: Apply template for new post only#9288
Merged
Conversation
Contributor
|
The e2e test breakage seems legitimate though |
Member
Author
|
I renamed the test case and I guess forgot to update the snapshot. See c25fc3a. |
Contributor
|
I think this branch made it so the demo content no longer loads. Though note that the way I found this PR was not due to code changes, it was simply looking at https://github.com/WordPress/gutenberg/commits/master, and "Packages: Make usage of |
Member
Author
|
Thanks for the note @jasmussen . Will look into it shortly. Related: We need an end-to-end test which simply loads the demo page. Though I suspect there are probably a fair number of other existing failures (console errors) which could cause the test to fail. |
This was referenced Aug 28, 2018
Member
Author
|
Created #9433 to track for release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #9287
This pull request seeks to resolve an issue where removing all blocks from a post with a template assigned would reintroduce the template blocks after saving and reloading the editor. This is in contrast with removal of a single block from template, where the edits would be respected.
It may be that we want to communicate to the user that the block content is in conflict with the template, or provide the option to insert the template for a truly-empty post, but the default behavior should respect the saved content of the user if they had removed the blocks in a previous session.
Testing instructions:
Verify that removing all blocks from a post with template, saving that post, and reloading the page, reflects that the blocks are still removed. I found this easiest by reusing the template plugin from within the test folder:
Then activate the plugin from Plugins screen in administration. This will enable a new Books post type with a default template.
Ensure end-to-end tests pass: