Merged
Conversation
Adds basic rendering dashicon unit tests. Related to #641. The Dashicon should not render when an icon is not provided.
Closed
Contributor
Author
Let's see! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic dashicon component tests. Covers cases where the tag name or
other properties are conditionally rendered. Related to progress on
#641. This PR adds the components directory to the list of entry points
configured for tests by webpack.
This introduces Enzyme and the react-test-renderer library as dev dependencies.
Testing Instructions
Run npm i && npm run test-unit ensure tests pass. Change Dashicon logic to ensure tests fail as they should.