Skip to content

Add mention of Material Design icons to the design docs.#9240

Merged
karmatosed merged 1 commit intomasterfrom
update/design-docs-iconset
Aug 23, 2018
Merged

Add mention of Material Design icons to the design docs.#9240
karmatosed merged 1 commit intomasterfrom
update/design-docs-iconset

Conversation

@kjellr
Copy link
Copy Markdown
Contributor

@kjellr kjellr commented Aug 22, 2018

As per the update in #8916, our core blocks now use Material Design icons. This PR updates our design doc about block design to reflect that.

Old:

Blocks should have an identifying icon, ideally using a single color. Try to avoid using the same icon used by an existing block. Look to Dashicons for style inspiration.

New:

Blocks should have an identifying icon, ideally using a single color. Try to avoid using the same icon used by an existing block. The core block icons are based on Material Design Icons. Look to that icon set, or to Dashicons for style inspiration.

As per the update in #8916, our core blocks now use Material Design icons. This PR updates our design doc about block design to reflect that.
@kjellr kjellr added [Type] Developer Documentation Documentation for developers Needs Design Feedback Needs general design feedback. labels Aug 22, 2018
@kjellr kjellr self-assigned this Aug 22, 2018
@kjellr kjellr requested a review from karmatosed August 22, 2018 13:27
Copy link
Copy Markdown
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this ⭐️

@karmatosed karmatosed merged commit 0cae578 into master Aug 23, 2018
@kjellr kjellr added this to the 3.7 milestone Aug 24, 2018
@kjellr kjellr deleted the update/design-docs-iconset branch August 24, 2018 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Design Feedback Needs general design feedback. [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants