Introduce strip_dynamic_blocks() for excerpts #8984
Merged
Conversation
Initially used when generating excerpts to avoid infinite loops when dynamic blocks generate excerpts, and to add parity with `strip_shortcodes()`.
Incompatible with PHP 5.2
Tests fix for #5572.
strip_dynamic_blocks() for excerpts
strip_dynamic_blocks() for excerpts
pento
approved these changes
Aug 16, 2018
Member
pento
left a comment
There was a problem hiding this comment.
This approach works for me: dynamic blocks are functionally equivalent to shortcodes for this use case, it's quite reasonable to just strip them out. Nice work on the hack to get around the lack of convenient filter. 😉
The docblocks need to be filled out, but the implementation is otherwise good. Feel free to merge once you've updated them. 🙂
Contributor
|
Very nice! Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aims to fix #7268 by adding parity with
strip_shortcodes()inwp_trim_excerpt().Aims to fix #5572 by removing dynamic blocks when generating excerpts to avoid infinite loops when dynamic blocks generate excerpts themselves.
How has this been tested?
I created a dynamic block that generated an excerpt in its callback, embedded it, and tested that it didn't create an out-of-memory error. Also added a small unit test to verify dynamic blocks are stripped.
Types of changes
get_shortcode_regex().strip_dynamic_blocks()function.strip_dynamic_blocks().strip_dynamic_blocks()when generating an excerpt.Checklist: