Fix our custom element serializer in IE11#8967
Conversation
abdfd6a to
8dfb3ce
Compare
8dfb3ce to
52e1c10
Compare
tofumatt
left a comment
There was a problem hiding this comment.
This is a pretty gnarly bug and I tested the fix in IE 11 on Windows 10–it fixed it, so I say 🚢
Were there any issues filed for this? I don't see them mentioned in the summary.
|
@tofumatt It's not filled I think, I just noticed it when fixing other IE11 bugs :) |
|
Agree that this was pretty critical to fix, but this needs to be refactored in a subsequent pull request since we're already assuming the fallback values in the assignment of the I can plan to set aside some time to take a look. |
|
@youknowriad thanks for fixing, and let's refactor :) |
|
I do suspect the main issue here is that our Babel runtime transform is converting the I've having trouble finding a way to detect true native environment support for Another option would be to avoid (re-)defining the React constants, and instead generate a dummy pair of |
|
For historical context, this was a regression of #8189 |
In IE11, React don't use the constants for its element types because of the lack of support for
Symbols. Which means in our element serializer we need to check against those numbers React uses as types.This fixes an issue where RichText content was not saved in IE11
Testing instructions