Merged
Conversation
1ae1625 to
e608ed3
Compare
noisysocks
approved these changes
Aug 13, 2018
Member
noisysocks
left a comment
There was a problem hiding this comment.
The code looks good! 👍
It would be nice if, after deleting a block, your cursor was positioned at the end of the previous block instead of at the start. Not a blocker though.
| // User is using the Remove Block shortcut, so allow the event to bubble | ||
| if ( altKey && metaKey && isReverse ) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I fear that, if we later change the shortcut, this code will be left here for the eternity of time... not sure how to fix that, though. Maybe let's explicitly mention the shortcut and component in the comment?
// User is using the Remove Block shortcut (Alt+Meta+Backspace), so allow the event to bubble up to <BlockSettingsMenu>e608ed3 to
4b3c3e6
Compare
4b3c3e6 to
178325e
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related #2980, #8279
onDeleteKeyDownfunctionHow has this been tested?
Screenshots
Block Settings Menu:
Shortcuts Help Modal
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: