WIP: Packages: Add the code editor package#8252
Closed
youknowriad wants to merge 1 commit intomasterfrom
Closed
Conversation
Member
|
Related: #8017 |
aduth
reviewed
Aug 30, 2018
| "@wordpress/components": "file:packages/components", | ||
| "@wordpress/compose": "file:packages/compose", | ||
| "@wordpress/core-data": "file:packages/core-data", | ||
| "@wordpress/core-editor": "file:packages/code-editor", |
Member
There was a problem hiding this comment.
Is this line intentional? core-editor , not code-editor ?
Contributor
Author
There was a problem hiding this comment.
definitely not :)
| @@ -0,0 +1,13 @@ | |||
| # Blob | |||
| Install the module | ||
|
|
||
| ```bash | ||
| npm install @wordpress/code-editor --save |
Member
There was a problem hiding this comment.
--save is not necessary (it's now default).
| let currentErrorAnnotations = [], | ||
| previouslyShownErrorAnnotations = []; | ||
|
|
||
| /** |
Member
There was a problem hiding this comment.
Tabbing alignment (various related issues with most functions in this file).
Contributor
Author
There was a problem hiding this comment.
You know, old style WP scripts 🤷♂️ I did some tweaks, but there's more we can do here :)
Contributor
Author
|
Blocked by a reliable lazy-loading approach |
Member
|
Do we need this anymore? |
Contributor
Author
|
Not anymore. We may want something like that later but fine to close now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the code editor package as a Gutenberg package. The code was copied as is from Core and tweaked a little bit:
This PR is not working yet because in the CodeEditor component, we try to do async loading of scripts and styles and for some reason the
load-scripts.phpis not returning thewp-code-editorscript and style (registered in Gutenberg), it only works for Core registered scripts/styles (I'll need a help from a WordPress Core expert here).