Packages: Adding RTL CSS support to the packages CSS#8187
Packages: Adding RTL CSS support to the packages CSS#8187youknowriad merged 2 commits intomasterfrom
Conversation
| .then( ( result ) => callback( null, result ) ); | ||
| }; | ||
|
|
||
| const postCSSRTLSync = ( ltrCSS, callback ) => { |
There was a problem hiding this comment.
Should we merge #8093 and refactor to use the asynchronous code?
There was a problem hiding this comment.
I don't really care which one goes first but yeah, we should align
| 'dom-ready', | ||
| ].map( camelCaseDash ) ), | ||
| new CopyWebpackPlugin( | ||
| gutenbergPackages.map( ( packageName ) => ( { |
|
Almost there, in case of |
gziolo
left a comment
There was a problem hiding this comment.
It works great, many thanks for fixing it.
🎉
|
Do we still need the Lines 50 to 54 in a9f6a1e It's also the sole plugin we use which hasn't been updated for Webpack 4 and would break with the upcoming Webpack 5 release.
|
|
I think when we merged this PR, we were in a mixed where not all the packages were in the packages folder but I think now it not necessary anymore. |
|
Okay, I'll plan to push up a pull request in the next day or so. |
|
Just to make sure it's tracked, I created an issue at #15146. I expect to find some time to look at this on Friday, and have assigned myself accordingly. |
This PR adds RTL support to the packages CSS which allows us to drop the root package folders for all the packages that expose CSS files.
There's a new Webpack step copying the built CSS files from the packages folder into the build folder used by the WordPress registered styles.
Testing instructions
nuxRTL CSS file is generated properly inbuild-styleand copied to the globalbuildfolder.