Skip to content

Omnipresent Toolbar: increase top padding in sidebar nav title#79083

Open
fushar wants to merge 1 commit into
trunkfrom
omnibar-sidebar-padding
Open

Omnipresent Toolbar: increase top padding in sidebar nav title#79083
fushar wants to merge 1 commit into
trunkfrom
omnibar-sidebar-padding

Conversation

@fushar

@fushar fushar commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What?

Fixes part of #77964 (comment)

Increase the padding between the sidebar title and the admin bar. Check the space on top of the < Design title:

Before After
image image

Why?

Fixing visual imbalance.

Testing Instructions

  1. Go to Gutenberg -> Experiments
  2. Enable the Omnipresent Toolbar experiment
  3. Go to Appearance -> Design
  4. Verify the sidebar looks better as above

Use of AI Tools

This PR is hand-written.

@github-actions github-actions Bot added the [Package] Edit Site /packages/edit-site label Jun 10, 2026
@fushar fushar self-assigned this Jun 10, 2026
@fushar fushar added the [Type] Enhancement A suggestion for improvement. label Jun 10, 2026
@fushar fushar marked this pull request as ready for review June 10, 2026 10:29
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @lucasmendes-design.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: lucasmendes-design.

Co-authored-by: fushar <fushar@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Size Change: +11 B (0%)

Total Size: 8.46 MB

📦 View Changed
Filename Size Change
build/styles/edit-site/experimental-omnibar-rtl.min.css 492 B +1 B (+0.2%)
build/styles/edit-site/experimental-omnibar.min.css 492 B +1 B (+0.2%)
build/styles/edit-site/style-rtl.css 22.1 kB +2 B (+0.01%)
build/styles/edit-site/style-rtl.min.css 18.2 kB +2 B (+0.01%)
build/styles/edit-site/style.css 22.1 kB +2 B (+0.01%)
build/styles/edit-site/style.min.css 18.2 kB +3 B (+0.02%)

compressed-size-action

@jasmussen

Copy link
Copy Markdown
Contributor

Nice. But you're up against this:

image

Shoulid the spacing be larger still? The top-padding in the existing site editor is 48px.

Note also that there are token-sizes you can use, SCSS variables instead of hard-coded numbers.

@github-actions

Copy link
Copy Markdown

Flaky tests detected in fe42060.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27269965886
📝 Reported issues:

@fushar

fushar commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Test mentioning @lucasmendes-design

@t-hamano t-hamano added [Type] Experimental Experimental feature or API. and removed [Type] Enhancement A suggestion for improvement. labels Jun 10, 2026
@lucasmendes-design

lucasmendes-design commented Jun 10, 2026

Copy link
Copy Markdown

Shoulid the spacing be larger still? The top-padding in the existing site editor is 48px.

I defer to @jasmussen on this. I'm happy both ways. 48px is fine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Edit Site /packages/edit-site [Type] Experimental Experimental feature or API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants