Rename Toolbar in editor experiment to match iteration issue#79074
Conversation
|
Size Change: 0 B Total Size: 8.46 MB 📦 View Changed
|
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
arthur791004
left a comment
There was a problem hiding this comment.
LGTM. Left some minor comments 🙂
| 'id' => 'gutenberg-admin-bar-in-editor', | ||
| 'label' => __( 'Toolbar in editor', 'gutenberg' ), | ||
| 'description' => __( 'Shows the Toolbar in the fullscreen Post and Site Editor.', 'gutenberg' ), | ||
| 'id' => 'gutenberg-omnibar', |
There was a problem hiding this comment.
nit: Maybe this is overthinking, but would it be better to migrate the existing flag to the new one as well, especially to ensure any unused flags are unset?
|
Flaky tests detected in 4f9a9c1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27261728963
|
What?
Renames the
Toolbar in editorexperiment toOmnipresent Toolbar, an umbrella term/codename, to match the corresponding iteration issue #79036.Why?
Trying to use the same language/terminology to promote a set of related changes.
The experiment might also include some UI changes. Showing toolbar (admin bar) in the editor is only one of the changes. Check the linked issue above for the list of changes.
Testing Instructions for Keyboard
Go to Gutenberg -> Experiments, enable the
Omnipresent Toolbaras shown below, go to Appearance -> Editor, verify the toolbar (admin bar) is still shown as expected.Screenshots or screencast
Use of AI Tools
I used Claude to do the refactor.