Skip to content

Fix sprintf format specifiers in post-date and read-more blocks#78933

Merged
t-hamano merged 2 commits into
WordPress:trunkfrom
Infinite-Null:fix/sprintf-format-specifiers
Jun 4, 2026
Merged

Fix sprintf format specifiers in post-date and read-more blocks#78933
t-hamano merged 2 commits into
WordPress:trunkfrom
Infinite-Null:fix/sprintf-format-specifiers

Conversation

@Infinite-Null

@Infinite-Null Infinite-Null commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

PR: #78912

Description

Fix missing $ positional argument identifiers in sprintf format strings across two block PHP files.

Changes

  • post-date: Fixed %1s%1$s and %2s%2$s in the <a> tag format string inside render_block_core_post_date().
  • read-more: Fixed %1s through %5s%1$s through %5$s in the <a> tag format string inside render_block_core_read_more().

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the [Package] Block library /packages/block-library label Jun 4, 2026
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Block] Post Date Affects the Post Date Block [Block] Read More Affects the Read More Block labels Jun 4, 2026

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano

t-hamano commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@Infinite-Null, can you resolve conflicts?

@Infinite-Null

Copy link
Copy Markdown
Contributor Author

Hi @t-hamano, I have resolved the conflict 🙌

@Infinite-Null Infinite-Null requested a review from t-hamano June 4, 2026 08:59
@t-hamano t-hamano merged commit e4b6b0b into WordPress:trunk Jun 4, 2026
39 checks passed
@github-actions github-actions Bot added this to the Gutenberg 23.4 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Post Date Affects the Post Date Block [Block] Read More Affects the Read More Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants