Fix: Gallery lightbox – clicking the expanded image should not close the dialog#78907
Draft
Mustafabharmal wants to merge 1 commit into
Draft
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Hi @Mustafabharmal, thanks for your work. I tested this PR, and it seems to be working, but we still need to change the cursor to the default when hovering over the image so it doesn't look like you can close the dialog by clicking it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When a Gallery block has lightbox enabled, clicking or tapping the expanded image inside the lightbox overlay no longer dismisses the dialog.
Closes #78869.
Why?
WordPress 7.0 introduced navigation controls (Previous / Next) for the Gallery lightbox (#62906). With those controls present, the image-click-to-close behaviour inherited from the standalone Image block became a UX problem: users tapping the image to inspect detail—or slightly mis-tapping while reaching for a navigation button—would accidentally dismiss the
lightbox with no way to recover other than reopening and navigating back.
On touch devices this is especially disruptive because hover isn't available and the image is the most prominent tap target in the overlay. This was also raised in #77545 and #55513.
How?
Added a new
handleOverlayClickaction inview.jsthat wraps the existinghideLightboxaction:IMGorFIGURE. If the click originated on the image, it returns early. If the click landed directly on the overlay backdrop, scrim, or Close button, it proceeds tohideLightbox.hideLightboxis called normally—no behaviour change.hideLightboxdirectly and is completely unaffected.handleOverlayClickbut since it is a<button>and not an<img>, it correctly dismisses the lightbox. Theindex.phplightbox overlay template is updated to bind the click event to the newhandleOverlayClickinstead ofhideLightbox.Testing Instructions
Screenshots or screencast