Post list: Remove close button from Quick Edit drawer#78730
Merged
Conversation
|
Size Change: -4 B (0%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jameskoster
approved these changes
May 28, 2026
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR!
Approving for design, but let's wait for a code review from @oandregal or @ntsekouras before merging.
oandregal
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #78726
Removes the header close button from the Quick Edit drawer in the Pages DataView.
Why?
The Quick Edit drawer had two affordances for dismissal: an X close button in the header and an explicit Cancel action in the footer. This created ambiguity — it was unclear whether closing via the X would save, discard, or prompt the user. Having two controls that appear similar but may imply different intent increases cognitive load.
This pattern has precedent in
AlertDialog, which intentionally omits a close button to force an explicit decision through the provided actions.How?
The close button in
PostCardPanelis conditionally rendered only when anonCloseprop is passed. The fix removes theonClose={ closeModal }prop fromPostCardPanelin both Quick Edit modal files:packages/edit-site/src/components/post-list/quick-edit-modal.jsroutes/post-list/quick-edit-modal.tsxThe interaction model is now unambiguous:
Testing Instructions
Testing Instructions for Keyboard
Tab.Enter.Tabthrough the form fields and footer buttons — only Cancel and Done should be reachable.Enteron Cancel to close, confirm drawer closes.Screenshots or screencast