Fix: stale missing blocks after persisted CRDT restore#78036
Draft
karthikeya-io wants to merge 1 commit into
Draft
Fix: stale missing blocks after persisted CRDT restore#78036karthikeya-io wants to merge 1 commit into
karthikeya-io wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#77796
What?
Closes
This PR invalidates persisted CRDT blocks when they contain a
core/missingblock whose original block type is now available again.Why?
When a block type is unavailable, Gutenberg renders it as
core/missing.With RTC persistence enabled, that stale
core/missingstate can be restored from the persisted CRDT document after the block type becomes available again. The editor then keeps renderingcore/missingafter reload, even though the block type is registered.How?
The persisted CRDT block comparison now also checks whether any restored
core/missingblock has anoriginalNamethat is currently registered.Testing Instructions
core/missing.Testing Instructions for Keyboard
Screenshots or screencast
Use of AI Tools