LinkControl: Allow filtering custom post type icons in search results#77748
Open
sarthaknagoshe2002 wants to merge 2 commits into
Open
LinkControl: Allow filtering custom post type icons in search results#77748sarthaknagoshe2002 wants to merge 2 commits into
sarthaknagoshe2002 wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #71491
Adds a JavaScript filter
blockEditor.linkControl.searchItemIconto the<SearchItemIcon />component to allow customizing the icon displayed in Link Control search suggestions.Why?
Currently, custom post types cannot display their registered icons within the Link Control search results. This PR solves this by exposing a filter, allowing developers to inject custom SVG icons for specific custom post types or suggestion types (custom tax).
How?
Wraps the resolved icon variable in the
SearchItemIconcomponent withapplyFilters. This passes the default icon and thesuggestion.type(post type) to the filter before rendering the final@wordpress/iconscomponent.Testing Instructions
Screenshots or screencast