Fix : Custom HTML overflow#77740
Open
Vrishabhsk wants to merge 2 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
pandblockquoteelements in the SandBox iframe overflow horizontally instead of wrapping.Why?
The Custom HTML block lets users paste arbitrary HTML including long unbreakable words like place names (
Taumatawhakatangihangakoauauotamateaturipukakapikimaungahoronukupokaiwhenuakitanatahu). When these are wrapped inporblockquotetags, two things go wrong:preand clipping onblockquote.save()function rendered raw HTML with no wrapper element and no block-level CSS, so the browser had no instruction to break long words.This makes valid HTML look broken to both the author and site visitors.
How?
Editor fix
In
packages/block-library/src/html/preview.js, theDEFAULT_STYLESstring that gets injected into the SandBox iframe was expanded:This sits alongside the existing
html,body,:rootreset and tells the iframe to break long words inside paragraphs and blockquotes instead of overflowing.Frontend fix
Three small changes ensure the same behavior on the published page:
save.js- Wrapped<RawHTML>in a<div className="wp-block-html">so the block has a targeting class. Without this, no frontend CSS could reach the raw HTML output.style.scss- New file with the sameoverflow-wrap: break-wordrule scoped to.wp-block-html pand.wp-block-html blockquote.block.json- Added"style": "wp-block-html"to register the new stylesheet.This pattern matches how the Quote, Pullquote, and Code blocks already prevent overflow.
Testing Instructions
pandblockquotewithout overflowing the content area.Use of AI Tools